core/types: Add allocation-free EffectiveGasTipInto method #31598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an allocation-free version of the Transaction.EffectiveGasTip method to improve performance by reducing memory allocations.
Changes
EffectiveGasTipInto
method that accepts a destination parameter to avoid memory allocationsEffectiveGasTip
method to use the new allocation-free implementationEffectiveGasTipValue
,EffectiveGasTipCmp
,EffectiveGasTipIntCmp
) to use the allocation-free approachMotivation
In high-transaction-volume environments, the
EffectiveGasTip
method is called frequently. Reducing memory allocations in this method decreases garbage collection pressure and improves overall system performance.Benchmark Results
As-Is
BenchmarkEffectiveGasTip/Original-10 42089140 27.45 ns/op 8 B/op 1 allocs/op
To-Be
BenchmarkEffectiveGasTip/IntoMethod-10 72353263 16.73 ns/op 0 B/op 0 allocs/op
Summary of Improvements
This optimization follows the same pattern successfully applied to other methods in the codebase, maintaining API compatibility while improving performance.
Safety & Compatibility
This optimization has no side effects or adverse impacts because:
This optimization follows the same pattern successfully applied to other methods in the codebase, providing better performance without compromising stability or correctness.