Moving to cvc5 and fixing it up #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
fix-cvc5-good
branch
from
3d5ff45 to
f81f5a0
Compare
|
nice! Our encoding is still not compatible with cvc5, but this is good by itself |
|
True, but it's not 100% unusable -- some things do work! :) I removed a test from here because it would conflict with the work of Zoe, but some tests do pass with CVC5. Once Zoe is done with her test fix-up, I can add some CVC5 tests, too, to demonstrate where it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes using cvc, now using cvc5. There was a bug in the
prelude-- lines cannot be cut by spec, but Z3 allows them to be cut, so this bug was not caught. The newcvc5requires a different option (--no-interactive) to get a "clean" interactive shell. Tests are NOT fixed up in this PR, because that would conflict with @zoep 's work on fixing up tests.NOTE: you must
rm -rf dist-newstylein order for yourcabal v2-replto correctly findcvc5. Unfortunately,cabal v2-replcaches your$PATHand if it changes, it will not be reflected next time your runcabal v2-repl. Socvc5will not be found. See haskell/cabal#2015 for details.