Add Hoodi config to network list #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dapper-rolypoly-9814ad ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
will default to `dev` variables, currently pointing to Hoodi which is desired
✅ Deploy Preview for phenomenal-frangipane-7c4bd1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
commented
Mar 26, 2025
| @@ -18,12 +18,14 @@ export enum NetworkChainId { | |||
| 'Mainnet' = 1, | |||
| 'Sepolia' = 11155111, | |||
| 'Holesky' = 17000, | |||
There was a problem hiding this comment.
Can open a separate PR to formally deprecate Holesky
There was a problem hiding this comment.
Yeah, I agree this is the right way to do that
CarlBeek
requested changes
Mar 27, 2025
| @@ -18,12 +18,14 @@ export enum NetworkChainId { | |||
| 'Mainnet' = 1, | |||
| 'Sepolia' = 11155111, | |||
| 'Holesky' = 17000, | |||
There was a problem hiding this comment.
Yeah, I agree this is the right way to do that
no longer using 0x42 as with previous testnets; aligning with Mainnet contract address: 0x00000000219ab540356cBB839Cbe05303d7705Fa
CarlBeek
approved these changes
Mar 27, 2025
|
Awesome, thanks @CarlBeek! Bringing in |
Maks199010
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
devand (to my knowledge) this feature branch.env.hoodi, updates.env.templateandsrc/utils/envVars.tsto use Hoodi over HoleskyPreview link
https://deploy-preview-745--dapper-rolypoly-9814ad.netlify.app/