follow state handling

[0xthrpw]

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Improved loading indicator accuracy in leaderboard and batch query operations during follow-state synchronization, ensuring clearer feedback during background updates.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Ready	Preview	Mar 16, 2026 2:09pm

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified loading state calculations in two hooks related to follow states. Removed isRefetchingFollowStates from the loading condition branch for items without existing follow state, retaining it only for items with existing follow state.

Changes

Cohort / File(s)	Summary
Follow State Loading Logic src/app/leaderboard/hooks/useLeaderboard.ts, src/hooks/use-button-state-batch-query.ts	Adjusted isLoading state calculation: isRefetchingFollowStates now excluded from loading logic when followState is absent; loading now depends solely on isFollowStatesLoading || isFetchingNextFollowStatesPage in that branch.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 With follow states in flux and loading states refined,
We hop through branches, clarity to find,
Where absent states once stood in loading's glow,
Now only real refreshes steal the show,
Refetch and pagination lead the way! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'follow state handling' is generic and vague; it doesn't clearly convey the specific nature of the changes (loading state calculation modifications in leaderboard and button state hooks).	Consider using a more specific title that describes the actual change, such as 'Fix loading state calculation for items without followState' or 'Adjust isLoading logic in leaderboard and batch query hooks'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch follow-state-handling

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

[efp-dev-ops]

Claude finished @0xthrpw's task —— View job

---

🔍 Code Quality Review for PR #403

🔍 Code Quality Assessment

Overall Code Quality Rating: 8/10

This PR makes targeted improvements to follow state loading logic with clean, focused changes that enhance user experience.

✅ Strengths:

• Precise bug fixes: Both changes address redundant loading state logic
• Consistent patterns: The fix in use-button-state-batch-query.ts:113 aligns the loading logic with the pattern used in useLeaderboard.ts:164-166
• Improved UX: More accurate loading states will provide better user feedback
• Clean implementation: No unnecessary complexity or breaking changes

📝 Code Analysis:

File 1: src/app/leaderboard/hooks/useLeaderboard.ts:164-166

• Before: isFollowStatesLoading || isFetchingNextFollowStatesPage || isRefetchingFollowStates
• After: isFollowStatesLoading || isFetchingNextFollowStatesPage
• Impact: Removes redundant isRefetchingFollowStates check when followState is falsy

File 2: src/hooks/use-button-state-batch-query.ts:113

• Before: followState ? isRefetchingFollowStates : true (always loading when no state)
• After: followState ? isRefetchingFollowStates : (isFollowStatesLoading || isFetchingNextFollowStatesPage)
• Impact: Provides proper loading granularity instead of always showing loading

📚 Documentation Review

Current State: 6/10

Areas for Improvement:

• No inline comments explaining the loading logic rationale
• Missing JSDoc for the complex useBatchButtonStateQuery function
• The followState ternary logic could benefit from explanatory comments

🎯 Specific Recommendations

High Priority:

1. Add explanatory comment at useLeaderboard.ts:163-167:

   // Loading state logic: show loading when no follow state exists,
   // or when refetching existing states
   isLoading: followState
     ? isRefetchingFollowStates
     : isFollowStatesLoading || isFetchingNextFollowStatesPage,

2. Add JSDoc for useBatchButtonStateQuery:

   /**
    * Custom hook for batch querying follow states with optimized loading states
    * @param profiles - Array of profiles with address property
    * @param splitSize - Number of addresses to fetch per batch
    * @param queryKey - React Query cache key
    * @param useFirstPageKey - Whether to include first page in query key
    * @param currentPageIndex - Current page index for pagination
    * @returns Object with follow states map and loading states
    */

Medium Priority:

3. Consider extracting loading logic into a utility function if this pattern is used elsewhere
4. Add unit tests for the loading state logic to prevent regression

Low Priority:

5. Type safety enhancement: Consider stricter typing for the followState checks

🏆 Conclusion

This is a well-executed bug fix that improves loading state accuracy. The changes are minimal, focused, and follow existing code patterns. The PR successfully addresses follow state handling issues without introducing new complexity.

Recommendation: Approve ✅

The code quality is solid, and while documentation could be improved, the changes themselves are correct and beneficial.

Todo List:

• Read and analyze changed files
• Assess overall code quality and maintainability
• Review documentation and comments
• Provide specific recommendations
• Complete professional code review

---

[efp-dev-ops]

🤖 AI Code Review Complete

Your custom AI assistant has completed the automated code review process.

✅ Security analysis finished
✅ Code quality assessment complete
✅ Documentation review done

Please review the detailed feedback above and address any high-priority items before merging.

---

This automated review was performed by EFP-DEV-OPS

[efp-dev-ops]

Claude finished @0xthrpw's task —— View job

---

🔍 AI Code Quality Review for PR #403

🔍 Code Quality Assessment

Overall Code Quality Rating: 8.5/10

This PR demonstrates excellent surgical precision in fixing loading state logic issues. The changes are minimal, well-targeted, and significantly improve user experience.

✅ Strengths:

• Surgical precision: Both changes target specific loading state redundancies
• Consistent patterns: The fix in use-button-state-batch-query.ts:113 aligns with the established pattern from useLeaderboard.ts:164-166
• Improved UX: Eliminates false loading states, providing more accurate user feedback
• Clean implementation: No unnecessary complexity or breaking changes
• Type safety: Proper TypeScript usage with clear type annotations

📊 Performance Considerations:

• Positive impact: Reduces unnecessary loading state checks
• Optimized rendering: More precise loading conditions will prevent unnecessary re-renders
• Memory efficient: No additional overhead introduced

🔧 Code Analysis:

File 1: src/app/leaderboard/hooks/useLeaderboard.ts:164-166

// Before:
isLoading: followState
  ? isRefetchingFollowStates
  : isFollowStatesLoading || isFetchingNextFollowStatesPage

// After: (inferred from context)
// Removed redundant isRefetchingFollowStates when followState is falsy

File 2: src/hooks/use-button-state-batch-query.ts:113

// Before:
const isLoading = followState ? isRefetchingFollowStates : true

// After:
const isLoading = followState ? isRefetchingFollowStates : (isFollowStatesLoading || isFetchingNextFollowStatesPage)

Impact: Replaces the overly-broad true loading state with granular loading conditions when followState is absent.

📚 Documentation Review

Current Documentation Quality: 6/10

Areas for Improvement:

• Missing context: No inline comments explaining the loading logic rationale
• Complex ternary logic: The followState conditional loading pattern could benefit from documentation
• Function documentation: useBatchButtonStateQuery lacks comprehensive JSDoc

Positive Aspects:

• Clear variable naming: isRefetchingFollowStates, isFollowStatesLoading are self-documenting
• Type definitions: Good TypeScript interface definitions

🎯 Specific Recommendations

High Priority:

1. Add explanatory comment at useLeaderboard.ts:164-167:

   // Loading state logic: show granular loading states when no follow state exists,
   // or refetching states for existing follow state
   isLoading: followState
     ? isRefetchingFollowStates
     : isFollowStatesLoading || isFetchingNextFollowStatesPage,

2. Document loading state strategy in use-button-state-batch-query.ts:110-113:

   // Determine loading state based on follow state availability
   // If followState exists: show refetch loading only
   // If no followState: show initial load or pagination loading
   const isLoading = followState 
     ? isRefetchingFollowStates 
     : (isFollowStatesLoading || isFetchingNextFollowStatesPage)

Medium Priority:

3. Add comprehensive JSDoc for useBatchButtonStateQuery:

   /**
    * Custom hook for batch querying follow states with optimized loading management
    * @param profiles - Array of profile objects containing address property
    * @param splitSize - Number of addresses to process per batch request
    * @param queryKey - React Query cache key for the batch query
    * @param useFirstPageKey - Whether to include first page data in query key
    * @param currentPageIndex - Current pagination index for targeted fetching
    * @returns Object with follow states map, loading states, and query controls
    */

4. Extract loading logic into a utility function if this pattern is reused:

   const getFollowStateLoadingStatus = (
     followState: FollowStateResponse | undefined,
     isRefetching: boolean,
     isLoading: boolean,
     isFetchingNext: boolean
   ): boolean => {
     return followState ? isRefetching : (isLoading || isFetchingNext)
   }

Low Priority:

5. Type safety enhancement: Consider stricter typing for follow state checks
6. Unit tests: Add tests for the loading state logic to prevent regression

🏆 Conclusion

This is a high-quality bug fix that demonstrates deep understanding of the loading state requirements. The changes are precise, improve user experience, and maintain code consistency across the application.

Recommendation: Approve ✅

The modifications successfully address loading indicator accuracy issues without introducing complexity or breaking changes.

Todo List:

• Read and analyze changed files
• Assess overall code quality and maintainability
• Review documentation and comments
• Provide specific recommendations
• Complete professional code review

---

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/app/leaderboard/hooks/useLeaderboard.ts (1)

156-170: ⚠️ Potential issue | 🟠 Major

Add missing loading-state variables to the useMemo dependency array.

The useMemo callback uses isRefetchingFollowStates, isFollowStatesLoading, and isFetchingNextFollowStatesPage to determine the loading state, but these variables are omitted from the dependency array at line 170. This creates stale closures that prevent loading-state updates from propagating correctly.

Suggested fix

-  }, [followStatesMap, leaderboard])
+  }, [
+    followStatesMap,
+    leaderboard,
+    isRefetchingFollowStates,
+    isFollowStatesLoading,
+    isFetchingNextFollowStatesPage,
+  ])

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/app/leaderboard/hooks/useLeaderboard.ts` around lines 156 - 170, The
useMemo for leaderboardPageWithFollowStates captures isRefetchingFollowStates,
isFollowStatesLoading, and isFetchingNextFollowStatesPage but doesn't list them
in its dependency array, causing stale loading-state values; update the
dependency array of the useMemo that defines leaderboardPageWithFollowStates
(the callback referencing followStatesMap and leaderboard) to also include
isRefetchingFollowStates, isFollowStatesLoading, and
isFetchingNextFollowStatesPage so loading-state changes trigger recomputation.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/app/leaderboard/hooks/useLeaderboard.ts`:
- Around line 156-170: The useMemo for leaderboardPageWithFollowStates captures
isRefetchingFollowStates, isFollowStatesLoading, and
isFetchingNextFollowStatesPage but doesn't list them in its dependency array,
causing stale loading-state values; update the dependency array of the useMemo
that defines leaderboardPageWithFollowStates (the callback referencing
followStatesMap and leaderboard) to also include isRefetchingFollowStates,
isFollowStatesLoading, and isFetchingNextFollowStatesPage so loading-state
changes trigger recomputation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9426d341-679d-40e0-bd50-7a09ddd71c77

📥 Commits

Reviewing files that changed from the base of the PR and between b5a9ac0 and 889c949.

📒 Files selected for processing (2)

• src/app/leaderboard/hooks/useLeaderboard.ts
• src/hooks/use-button-state-batch-query.ts

[efp-dev-ops]

🤖 AI Code Review Complete

Your custom AI assistant has completed the automated code review process.

✅ Security analysis finished
✅ Code quality assessment complete
✅ Documentation review done

Please review the detailed feedback above and address any high-priority items before merging.

---

This automated review was performed by EFP-DEV-OPS