Laravel 6 #324
Open
Laravel 6 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etrepat Any plan for merging this and adding support for Laravel 6.x? |
jmarcher
suggested changes
Nov 25, 2019
| @@ -352,7 +352,11 @@ protected function fireMoveEvent($event, $halt = true) { | |||
| // but we relay the event into the node instance. | |||
| $event = "eloquent.{$event}: ".get_class($this->node); | |||
|
|
|||
| $method = $halt ? 'until' : 'fire'; | |||
| if (version_compare(app()->version(), '5.8.0', '>=')) { | |||
There was a problem hiding this comment.
You can compare against 5.4, this method was deprecated there.
But personally I would not check against it. I would make v2.0 require Laravel >=5.4
|
@mkwsra @eduardokum Version 2 already supports Laravel 6 (has some breaking changes), hope to see Laravel 7 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.