Promote development to master#661
Merged
Merged
Conversation
Adds sanitized server boundary logging and a narrow client error bridge for critical transaction failures.
Filter refinance debt and collateral selections so each choice leaves a compatible counterpart, and keep the modal grouping explicit when no compatible vaults remain.
…ration # Conflicts: # components/entities/operation/OperationReviewModal.vue # package-lock.json # package.json # pages/position/[number]/borrow/swap.vue # pages/position/[number]/collateral/swap.vue # pages/position/[number]/index.vue # utils/sdk-snapshot-populate-stubs.ts
- add refinance entries to the batch builder - keep simulated position highlights and removed rows scoped to changed assets - decode batch execution errors and separate quoted amounts from verifier minimums
- constrain collateral query selection to position collaterals - preserve network query in refinance navigation - resolve modal selections by selected vault address - include all source collateral vaults in refinance replacement metadata - fix disconnected submit guards and wallet address normalization
Wrap vault overview sections in reusable accordion cards with configurable default open states across standard, pair, and Securitize views.
…15-convert-vault-page-sections-to-accordion-style # Conflicts: # components/entities/vault/overview/SecuritizeVaultOverview.vue # components/entities/vault/overview/VaultOverview.vue # components/entities/vault/overview/VaultOverviewBlockGeneral.vue
Collapse a vault overview accordion by default when it is the only accordion section in its parent view.
Force a lone vault overview accordion section open after mount so single-section views show their content by default.
Keep accordion actions before a far-right chevron so sections with badges retain the same expand affordance as other rows.
Make the full vault overview accordion header toggle the section while keeping header actions independently clickable.
Polish the vault open interest graph with card-based nodes, responsive mobile stacking, and data-aware spacing for dense collateral sets.
Remove the standalone vault-page open interest chart and add a compact Explore matrix Open Interest view grouped by backing asset, including duplicate-vault counts for aggregated exposures.
Limit the matrix Open Interest view to the first four borrow-vault cards by default and add a Show more/Show less control for dense markets.
Keep every borrow-vault card visible in the matrix Open Interest view, but collapse each card's backing-asset rows after the top three with a per-card Show more control.
Center the per-card Show more control in the matrix Open Interest view.
Show token avatars next to borrow and backing asset symbols in the matrix Open Interest view.
Surface default borrow filters in the active filter chips and keep unavailable discovery matrix cells passive.
Drops the redundant 'Can be used as collateral' field from vault overview surfaces now that collateral exposure is covered by the matrix/open-interest work.
Adds shared backing-asset grouping for exposure data and applies it across lend rows, lend exposure details, earn rows, and earn vault exposure sections.
…-redaction fix: redact upstream URL paths in logs
…rest-section-to-vault-page-sankey-style-flow feat: add grouped exposure views
LeonardEulerXYZ
left a comment
Contributor
There was a problem hiding this comment.
Leonard review — PR #661
Verdict: Comment — no approval submitted.
Reviewed current head 3d097739cfde203508c033c6ae4ec9fada6bbc4a for the development → master promotion.
What I checked:
- Release/master-promotion diff against
origin/master, including server proxy/observability changes, bad-debt discovery/overview changes, and related tests. - Prior Leonard findings from the previous head: the bad-debt zero/matrix issue is fixed, and the old malformed-subgraph/path-template comments were obsolete against this head.
- Bot/reviewer feedback: no active non-Leonard inline review comments remained to verify on the current head.
- Security/malicious-code sweep over changed server/API/proxy/dependency/workflow surfaces; no malicious-code or supply-chain issue found.
- Scalability / maintainability hygiene pass: the bad-debt display path now uses shared helpers/tests rather than a one-off component patch; I did not find a sibling overview/matrix surface still carrying the old loaded-zero inconsistency.
Validation:
npm run test:run -- tests/server/observability.test.ts tests/server/subgraph-proxy-route.test.ts tests/server/client-error.test.ts tests/server/v3-proxy.test.ts tests/server/screen-address.test.ts tests/utils/client-observability.test.ts tests/utils/discovery-calculations.test.ts tests/utils/vault-bad-debt.test.ts tests/composables/useCustomFilters.test.ts— 46/46 tests passed.npm run typecheck— passed.npm run build— passed. Only existing Vite/Rollup chunking and sourcemap-style warnings observed.- Light deployed-app smoke on the development deployment:
/,/borrow?network=1, and/explore?network=1rendered real app content on desktop and mobile headed Chromium. Wallet/signing smoke not run.
Smoke coverage: route/API smoke + desktop/mobile browser smoke. No screenshots posted because this pass did not validate a specific visual delta; it was a promotion-level route/render sanity pass.
One non-blocking hardening note remains inline: sanitized URL fields are much improved, but logging raw err / err.message can still reintroduce malformed configured target strings through fetch/URL parse error messages. That is narrower than the previous blocker, but worth closing before relying on these failure logs as fully redacted.
Hide bad debt and open-interest surfaces when the V3 backend is disabled, while preserving soft unavailable states for enabled fetch failures.
257: Extend refinance to migrate collateral
fix: gate v3-only metrics
Keep the static collateral/LTV overview visible when the V3 backend is disabled while continuing to gate live exposure values on open interest data.
fix: preserve collateral config without v3
…-page-sections-to-accordion-style feat: add vault overview accordions
Avoid logging raw URL-bearing error messages from proxy failure paths while preserving bounded error metadata for debugging.
fix: sanitize proxy error logs
VSBDev
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developmentbranch tomaster.Changelist
Features
Fixes
$0for borrowable Explore matrix rows (fix: show zero loaded bad debt #664) @SerangedDependencies
Validation
origin/master..origin/developmentpromotion diff and all contained merge commits, including PRs merged into feature branches before those branches landed ondevelopment.