Add Binance Wallet quote source#90
Conversation
90f58b6 to
7fd49a9
Compare
LeonardEulerXYZ
left a comment
There was a problem hiding this comment.
Walkthrough
Overview
Adds binance-wallet as a custom Balmy quote source, wires signed Binance Web3 quote/swap requests into the aggregator source list, adds credentials to .env.template, and extends the source alias expansion so configured/provider-selected aliases still compose with the existing Pendle expansion.
Review effort
Medium. I reviewed the full diff, the new Binance Wallet source, the strategy filter/alias wiring, credential handling, and the signed request path. I also ran a local mocked quote/buildTx smoke for the source. Live Binance quote execution remains intentionally unverified until staging/prod credentials are configured.
Validation
Reviewed head: 7fd49a96d103714b017507cb6bb12753b958c7e7
git diff --check origin/development...HEADpnpm install --frozen-lockfilepnpm run lintpnpm run build- Local throwaway
tsxsmoke forCustomBinanceWalletQuoteSource: mocked quote routes selected the best SWAP route, applied slippage, built swap tx calldata/value, and attachedX-OC-*signature headers. - Security/supply-chain sweep over the diff: no dependency/lockfile/workflow changes; new network surface is limited to signed requests to
https://web3.binance.com; no hardcoded secret values added.
Verdict
Comment only — no blocking findings found.
Notes
- The source correctly refuses to quote/build tx without both Binance Wallet credentials.
- Binance live behavior still needs the PR’s own pending test-plan item once real credentials exist: one live quote + swap-build response shape check.
- No inline comments from me; nothing I saw merits blocking the PR.
7fd49a9 to
e858124
Compare
e858124 to
b072122
Compare
Summary
Changes
binance-walletprovider instead of vendor-specific sub-sources.BINANCE_WALLET_API_KEYandBINANCE_WALLET_SECRET_KEY..env.template.Test plan
pnpm run lintpnpm run buildgit diff --checkbinance-walletis exposed