Pr/keycloak preparations 1 - #116
Open
RakanHowls wants to merge 3 commits into
Open
RakanHowls wants to merge 3 commits into
RakanHowls wants to merge 3 commits into
Conversation
…ak needs that - and the old IDP just ignored that parameter it seems
Author
|
PS: Is the app functionality used right now? I don't see config about that in the helm chart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.ory.com/docs/oauth2-oidc/authorization-code-flow talks about redirect_uri and not redirect_url - it seems that is just ignored and it falls back to the pre-configured redirect.
The OAuth standard says it should be redirect_uri - so we should probably fix that for KeyCloak - which definitely wants redirect_uri and I don't know how it would react to the typo.
The redirect_uri in the token is for the IDP<->auth service exchange - not the redirect to the app that is using the auth service. The IDP needs to drop off at the auth service - which then goes to the dropoff in the app.