Models Code Cleanup WIP #3346
Draft
Models Code Cleanup WIP #3346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tn3rb
force-pushed
the
models-cleanup/main
branch
3 times, most recently
from
1dbd285 to
0d2ddad
Compare
tn3rb
force-pushed
the
models-cleanup/main
branch
from
0d2ddad to
a2b9873
Compare
tn3rb
force-pushed
the
models-cleanup/main
branch
from
a2b9873 to
de94a1b
Compare
tn3rb
force-pushed
the
models-cleanup/main
branch
2 times, most recently
from
b2577ac to
dca714c
Compare
tn3rb
force-pushed
the
models-cleanup/main
branch
from
dca714c to
25ba4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the following to files within the
core/db_classes&&core/db_modelsfolders:formats to PSR12 standards
updates/adds phpdocs
declares all exceptions
extracts some logic into new methods (rare)