Skip to content

Fix Caching Loader Test #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: dev
Choose a base branch
from
Open

Fix Caching Loader Test #3970

wants to merge 32 commits into from

Conversation

@tn3rb
Copy link
Member

@tn3rb tn3rb commented Jul 27, 2022

Online tests for both master and dev branch are failing with the following error:

There was 1 failure:

1) CachingLoaderTest::testResetCache
Failed asserting that actual size 3 matches expected size 0.

/event-espresso-core/tests/testcases/core/services/loaders/CachingLoaderTest.php:132

tests pass locally of course 😡

@tn3rb tn3rb self-assigned this Jul 27, 2022
tn3rb added 28 commits July 28, 2022 13:03
@tn3rb
use reset registry
181ac72
@tn3rb
add InterminableInterface
7392e01
@tn3rb
add InterminableInterface + typing + formatting
aab2e31
@tn3rb
fix method calls
8bdfd2f
@tn3rb
set default value
279213d
@tn3rb
sort and de-dupe FQCN arrays
9a83816
@tn3rb
improve add() and typings
aded9bb
@tn3rb
don't reset Interminable. improve reset()
f1fc874
@tn3rb
add/improve typings
c91b110
@tn3rb
add import
28654c2
@tn3rb
clear stack b4 adding more
923db7b
@tn3rb
fix typings
badeef8
@tn3rb
fix return type
aa36849
@tn3rb
fix duplicate asset handles
cee0a09
@tn3rb
fix another duplicate handle
b692edf
@tn3rb
improved reset & addon caching
5e0dae2
@tn3rb
set DRS from config
099cb4b
@tn3rb
fix & format tests
cd3ea8b
@tn3rb
refactor/extract validator logic
c11ef3a
@tn3rb
extend LoaderFactory
db62bff
@tn3rb
another whoops! fix types
dc5501d
@tn3rb
get EmailValidationService manually
5328275
@tn3rb
don't need < 5.6 helper
8c58b66
@tn3rb
use constant + formatting
24e8476
@tn3rb
use constant (and correct data type)
2f17663
@tn3rb
use constants
1fe817d
@tn3rb
add prop, get, & set for EmailValidationService
804b047
@tn3rb
fix typings & format
925c8b7
@tn3rb tn3rb force-pushed the fix-caching-loader-test branch from 55a7373 to 4556b6b Compare July 28, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tn3rb tn3rb

Labels

category:unit-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tn3rb