Skip to content

Conversation

@man-andy
Copy link

Problem this Pull Request solves

There is no translation for the 'for' label in the ticketname

How has this been tested

Create a waitlist and open the dropdown.
image

Checklist

@tn3rb
Copy link
Member

tn3rb commented Dec 1, 2022

OOF! well that was an oversight!

Thanks for the submission @man-andy

@tn3rb
Copy link
Member

tn3rb commented Dec 1, 2022

@man-andy

I'm thinking we should return a single translated string and use placeholders for the dynamic content like:

sprintf(
    esc_html__('%1$s @ $2$s for $3$s', 'event_espresso'),
    $this->name(),
    implode(', ', $times),
    $this->pretty_price()
);

this will allow for languages that may want/need to rearrange the order of the words.

I can either go ahead and just make that change, but if you want to have the actual contribution credited to you and appear in your github history, then you can simply ammend your PR. This will also need a translators comment too.

@man-andy
Copy link
Author

man-andy commented Dec 6, 2022

@tn3rb Hi, can you make the change? I am on vacation this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants