Cache Rework Part 1 #413
Merged
Cache Rework Part 1 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crypta-Eve
added a commit
that referenced
this pull request
Jan 24, 2025
This reverts commit dad4e68.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back some cache functionality as it used to exist within SeAT v4.
The intent is that for most jobs (exclusions based on ETAG reliability and complexity of responses/handling), if the result is cached then do not try and insert it into the DB. In a lot of cases, this should lead to fewer DB writes.
There is a new ENV var that will be added as part of this change, which is
EVEAPI_RESPECT_CACHEIt defaults to false, which will not check if an ESI response is cached and always treat it as new data (as has been the case in SeAT v5 until now)enables this behavior. This can be set to
truein order to trial the v4 style caching. In a future release this default may get changed to true.Future work on the cache will follow will aim at reducing the size of the cache itself.