Consistently parses Authy API response body as JSON #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evilpacket Please take a look and let us know what you think! |
|
Way more clean that how it was being done before. I'll merge doing a version bump and publish. Thanks for the PR. |
|
Great, thanks. |
|
Hi @evilpacket, any thoughts on when this might be merged in? |
|
lol. I thought I did merge this and published the other version because I did. |
evilpacket
pushed a commit
that referenced
this pull request
Jun 20, 2014
Consistently parses Authy API response body as JSON
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses request library's JSON option instead of toJSON function and does so for all APIs.