Skip to content

test(nitro): await the dev server before issuing requests - #763

Merged
HugoRCD merged 1 commit into
mainfrom
test/nitro-v3-await-ready
Oct 2, 2026
Merged

HugoRCD merged 1 commit into
mainfrom
test/nitro-v3-await-ready

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Oct 2, 2026

Copy link
Copy Markdown
Member

test/nitro-v3/nitro-v3.test.ts built request URLs from server.url right after devServer.listen({}). srvx binds asynchronously and leaves url undefined until the listener is up, so on a slow runner every test in the file failed with TypeError: Invalid URL. The evi production deploy for 18f575c6 hit this (8 failures) two minutes after the same suite passed for aebed601 in the same sandbox.

beforeAll now awaits server.ready() after the first build.

Before (Vercel build log, evi-l5zrmga5k):

FAIL  test/nitro-v3/nitro-v3.test.ts > Nitro v3 Server with evlog > should be able to get the correct result
TypeError: Invalid URL
Tests  8 failed | 1997 passed (2005)

After, locally: test/nitro-v3/nitro-v3.test.ts 8 passed.

No changeset: test-only.

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
evi Ready Ready Preview Oct 2, 2026 4:46pm UTC
evlog-telemetry Ready Ready Preview Oct 2, 2026 4:46pm UTC
3 Skipped Deployments
Project Deployment Actions Updated
evlog-docs Skipped Skipped v0 Oct 2, 2026 4:46pm UTC
evlog-render-lab Skipped Skipped Oct 2, 2026 4:46pm UTC
just-use-evlog Skipped Skipped Oct 2, 2026 4:46pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – evlog-docs October 2, 2026 16:43 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-render-lab October 2, 2026 16:43 Inactive
@vercel
vercel Bot temporarily deployed to Preview – just-use-evlog October 2, 2026 16:43 Inactive
@github-actions github-actions Bot added the test label Oct 2, 2026
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dfeb4d44-0e69-4b61-a104-f5b49665f448

📥 Commits

Reviewing files that changed from the base of the PR and between 18f575c and e468aa5.

📒 Files selected for processing (1)
  • packages/evlog/test/nitro-v3/nitro-v3.test.ts
 ________________________________________________
< Doubling as a space heater during code review. >
 ------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@HugoRCD HugoRCD changed the title test(nitro-v3): await the dev server before issuing requests test(nitro): await the dev server before issuing requests Oct 2, 2026
@HugoRCD
HugoRCD merged commit 77f757e into main Oct 2, 2026
15 of 19 checks passed
@HugoRCD
HugoRCD deleted the test/nitro-v3-await-ready branch October 2, 2026 16:44

This branch was successfully deployed

2 active and 3 inactive deployments
Preview – evlog-telemetry — e468aa58 Deployed Oct 2, 2026 by vercel[bot]
Preview – evi — e468aa58 Deployed Oct 2, 2026 by vercel[bot]
Preview – evlog-docs — e468aa58 Deployed Oct 2, 2026 by vercel[bot]
Preview – evlog-render-lab — e468aa58 Deployed Oct 2, 2026 by vercel[bot]
Preview – just-use-evlog — e468aa58 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant