Repository navigation
feat(telemetry): add express and fastify framework icons - #781
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Adoption tab's Frameworks card fell back to a generic box glyph and the raw slug for the two frameworks the CLI added most recently:
expressandfastifyrendered as an anonymous package icon labeled "express" / "fastify", while every other CLI framework got its own mark and display name.Change
apps/telemetry/shared/utils/field-dimensions.ts, the same maps the other five ids live in:Chart color slots are untouched: both keep the neutral
otherband, which the updated test now asserts explicitly.Evidence
Verified in the sandbox against this branch (
4545019): seededevlog-climap runs withmapFramework: express/fastifythrough a local dev server, then read the rendered Adoption tab. Both rows carry the real simple-icons glyphs (i-simple-icons:express,i-simple-icons:fastify, confirmed in the DOM via their SVG mask data URLs) and the labels "Express" / "Fastify" instead of the raw slugs. Screenshot captured in the requesting thread; the Blob store refused a public upload this session, so it is not attached here.Checks
pnpm vitest run test/field-dimensions.test.ts: 14 passed, including the widened seven-id icon/label looppnpm lintandpnpm typecheckinapps/telemetry: cleanNo changeset: the change is confined to
apps/telemetry.ELI5
The telemetry dashboard lists which frameworks people use evlog with. The two newest ones, Express and Fastify, showed up with a plain generic icon and their name written in lowercase code-speak. This gives them their proper logos and properly capitalized names, matching the other frameworks on the list.