Repository navigation
fix: preserve the GitHub telemetry handle and accept action events - #782
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thank you for following the naming conventions! 🙏 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix
createGitHubActionsTelemetry()losing prototype members when spreading its class instance. The returned handle now exposesset(),flush(), and a liveenabledgetter. Includes a patch changeset and a regression reproduced before the fix.Accept
evlog-actionin the telemetry dashboard with an explicit custom-field allowlist. Keep deployment overrides authoritative and drop undeclared repository fields.Companion to evloghq/action#8. Deploy the ingest change before releasing that action.
Validation
Full lint, tests, and coverage pass. SDK handle and dashboard ingest regressions pass; shared
DO_NOT_TRACK/EVLOG_TELEMETRYopt-outs are covered.CI-scope typecheck passes (28/28 tasks). Dashboard typecheck passes via the root executable:
pnpm exec vue-tsc -b apps/telemetry/.nuxt/tsconfig.json --noEmit.pnpm run typecheckremains blocked by a stale app-local vue-tsc 3.2.7 launcher pointing to a missing module, including after a frozen-lockfile reinstall. No dependency versions or generated launchers changed.