Repository navigation
fix(telemetry): accept the errorStage custom field from evlog-action - #786
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
errorStagejoins theevlog-actioncustom-key allowlist, so failures recorded byevloghq/actionsurvive ingestion instead of being dropped byparseIngestBody().The action side of this is evloghq/action#9: when the action's work throws, it tags the error with the stage it reached (
inputs,baseline,cli,check,comment) and setserrorStageon the telemetry event before the fixedACTION_EXECUTION_FAILEDcode is reported. Until this PR, that field was silently stripped on arrival and every failure looked like every other failure.Evidence
Failing before the allowlist change, passing after (regression test first, then the fix):
The diff is the field plus its fixture entry:
'commentOutcome', + 'errorStage', 'packages',Checks
pnpm --filter evlog-telemetry exec vitest run test/action-ingest.test.ts: 3 passed (observed after the fix)TURBO_REMOTE_CACHE_READ_ONLY=true pnpm turbo run lint typecheck --filter=evlog-telemetry: 7/7 successfulNo changeset: confined to
apps/telemetry.ELI5
The action sends a small note with every failure saying which step it died on. The server that collects those notes only accepts notes on a list, and this step name wasn't on it, so the note was thrown away. This adds it to the list, so failed runs in the dashboard will finally say where they broke.