Skip to content

fix(telemetry): accept the errorStage custom field from evlog-action - #786

Merged
HugoRCD merged 1 commit into
mainfrom
fix/telemetry-ingest-error-stage
Oct 6, 2026
Merged

HugoRCD merged 1 commit into
mainfrom
fix/telemetry-ingest-error-stage

Conversation

@evlogai

@evlogai evlogai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

What

errorStage joins the evlog-action custom-key allowlist, so failures recorded by evloghq/action survive ingestion instead of being dropped by parseIngestBody().

The action side of this is evloghq/action#9: when the action's work throws, it tags the error with the stage it reached (inputs, baseline, cli, check, comment) and sets errorStage on the telemetry event before the fixed ACTION_EXECUTION_FAILED code is reported. Until this PR, that field was silently stripped on arrival and every failure looked like every other failure.

Evidence

Failing before the allowlist change, passing after (regression test first, then the fix):

❯ test/action-ingest.test.ts (3 tests | 2 failed)
   × accepts action metadata, aggregate scan totals and reporting outcomes
   × drops repository data and undeclared fields
     → 'errorStage' is dropped by parseIngestBody, custom no longer equals the fixture

✓ test/action-ingest.test.ts (3 tests) 6ms

The diff is the field plus its fixture entry:

     'commentOutcome',
+    'errorStage',
     'packages',

Checks

  • pnpm --filter evlog-telemetry exec vitest run test/action-ingest.test.ts: 3 passed (observed after the fix)
  • TURBO_REMOTE_CACHE_READ_ONLY=true pnpm turbo run lint typecheck --filter=evlog-telemetry: 7/7 successful

No changeset: confined to apps/telemetry.

ELI5

The action sends a small note with every failure saying which step it died on. The server that collects those notes only accepts notes on a list, and this step name wasn't on it, so the note was thrown away. This adds it to the list, so failed runs in the dashboard will finally say where they broke.

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
evlog-telemetry Building Building Preview Oct 6, 2026 5:06pm UTC
4 Skipped Deployments
Project Deployment Actions Updated
evi Skipped Skipped Oct 6, 2026 5:06pm UTC
evlog-docs Skipped Skipped v0 Oct 6, 2026 5:06pm UTC
evlog-render-lab Skipped Skipped Oct 6, 2026 5:06pm UTC
just-use-evlog Skipped Skipped Oct 6, 2026 5:06pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 058203f7-bf57-4829-a225-20cae0e39753

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@pkg-pr-new

pkg-pr-new Bot commented Oct 6, 2026

Copy link
Copy Markdown
@evlog/cli

npm i https://pkg.pr.new/@evlog/cli@786

evlog

npm i https://pkg.pr.new/evlog@786

@evlog/nuxthub

npm i https://pkg.pr.new/@evlog/nuxthub@786

@evlog/signals

npm i https://pkg.pr.new/@evlog/signals@786

@evlog/telemetry

npm i https://pkg.pr.new/@evlog/telemetry@786

commit: a40820a

@HugoRCD
HugoRCD merged commit fb839a8 into main Oct 6, 2026
18 of 19 checks passed
@HugoRCD
HugoRCD deleted the fix/telemetry-ingest-error-stage branch October 6, 2026 17:08

This branch was successfully deployed

1 active and 4 inactive deployments
Preview – evlog-telemetry — a40820a7 Deployed Oct 6, 2026 by vercel[bot]
Preview – evlog-docs — a40820a7 Deployed Oct 6, 2026 by vercel[bot]
Preview – evlog-render-lab — a40820a7 Deployed Oct 6, 2026 by vercel[bot]
Preview – evi — a40820a7 Deployed Oct 6, 2026 by vercel[bot]
Preview – just-use-evlog — a40820a7 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant