Skip to content

feat(evi): request native Slack approval for external PR reviews - #789

Draft
HugoRCD wants to merge 3 commits into
mainfrom
feat/evi-external-pr-review
Draft

HugoRCD wants to merge 3 commits into
mainfrom
feat/evi-external-pr-review

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Hand off external PR events to native durable Slack approval. Skip Hugo/Evi-authored and ineligible PRs before dispatch, without a metadata fetch.
  • Remove the synthetic approval model and separate state module. The trigger has no queue or approval store.
  • Bound the approval-only provider call to a fixed prompt, the preparation tool and 256 output tokens. Reject other model tool calls before approval.
  • After approved exact-head checkout, run the review skill and publish scoped COMMENT reviews with apply-ready suggestions. Never modify contributor branches, approve or merge.

Validation

Evi typecheck, changed-file ESLint, repository lint/tests, coverage, content lint and compile-only build passed.

Test Files  46 passed (46)
     Tests  337 passed (337)

Offline SDK tests cover approve/cancel, failed preparation and rejected unexpected generate/stream calls. Exact-head and restricted-write regressions pass. Repository-wide typecheck remains blocked by telemetry's missing vue-tsc.

Remaining validation

  • Complete signed-webhook and native Slack approve/cancel integration remains untested.
  • Duplicate deliveries can create multiple approval requests. Publication is not externally idempotent across interrupted replay.
  • Full replay, compaction and non-model capability paths remain unverified. Ordinary messages in the dedicated review channel are ignored.

Configuration

EVI_PR_REVIEW_SLACK_CHANNEL_ID=C0C82S9SGSU is set for Vercel Production and Preview.

No deployment or live model evals were run. Apps-only change, so no changeset. Unrelated memory work remains stashed.

@vercel
vercel Bot temporarily deployed to Preview – evlog-docs October 6, 2026 21:32 Inactive
@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
evi Ready Ready Preview Oct 6, 2026 10:38pm UTC
4 Skipped Deployments
Project Deployment Actions Updated
evlog-docs Skipped Skipped Oct 6, 2026 10:38pm UTC
evlog-render-lab Skipped Skipped Oct 6, 2026 10:38pm UTC
evlog-telemetry Skipped Skipped Oct 6, 2026 10:38pm UTC
just-use-evlog Skipped Skipped Oct 6, 2026 10:38pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – evlog-render-lab October 6, 2026 21:32 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-telemetry October 6, 2026 21:32 Inactive
@vercel
vercel Bot temporarily deployed to Preview – just-use-evlog October 6, 2026 21:32 Inactive
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@pkg-pr-new

pkg-pr-new Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
@evlog/cli

npm i https://pkg.pr.new/@evlog/cli@789

evlog

npm i https://pkg.pr.new/evlog@789

@evlog/nuxthub

npm i https://pkg.pr.new/@evlog/nuxthub@789

@evlog/signals

npm i https://pkg.pr.new/@evlog/signals@789

@evlog/telemetry

npm i https://pkg.pr.new/@evlog/telemetry@789

commit: 815799e

@vercel
vercel Bot temporarily deployed to Preview – just-use-evlog October 6, 2026 21:54 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-telemetry October 6, 2026 21:54 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-render-lab October 6, 2026 21:54 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-docs October 6, 2026 21:54 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-telemetry October 6, 2026 22:34 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-render-lab October 6, 2026 22:34 Inactive
@vercel
vercel Bot temporarily deployed to Preview – just-use-evlog October 6, 2026 22:34 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-docs October 6, 2026 22:34 Inactive

This branch was successfully deployed

1 active and 4 inactive deployments
Preview – evi — 815799e6 Deployed Oct 6, 2026 by vercel[bot]
Preview – evlog-render-lab — 815799e6 Deployed Oct 6, 2026 by vercel[bot]
Preview – evlog-docs — 815799e6 Deployed Oct 6, 2026 by vercel[bot]
Preview – just-use-evlog — 815799e6 Deployed Oct 6, 2026 by vercel[bot]
Preview – evlog-telemetry — 815799e6 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant