Skip to content

refactor(ai): reuse formatTelemetryError and the recordModel resolution #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HugoRCD merged 1 commit into from
Oct 9, 2026
Merged

refactor(ai): reuse formatTelemetryError and the recordModel resolution #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/evlog/src/ai/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,10 +790,11 @@ function flushState(log: RequestLogger, state: AccumulatorState): void {
}
}

function recordModel(state: AccumulatorState, provider: string, modelId: string, responseModelId?: string): void {
function recordModel(state: AccumulatorState, provider: string, modelId: string, responseModelId?: string): { provider: string, model: string } {
const resolved = resolveProviderAndModel(provider, responseModelId ?? modelId)
state.models.push(resolved.model)
state.lastProvider = resolved.provider
return resolved
}

function safeParseJSON(input: string): unknown {
Expand All @@ -807,11 +808,10 @@ function safeParseJSON(input: string): unknown {
function recordError(log: RequestLogger, state: AccumulatorState, model: { provider: string, modelId: string }, error: unknown): void {
state.calls++
state.steps++
recordModel(state, model.provider, model.modelId)
const resolved = recordModel(state, model.provider, model.modelId)
state.lastFinishReason = 'error'
state.lastError = error instanceof Error ? error.message : String(error)
state.lastError = formatTelemetryError(error)

const resolved = resolveProviderAndModel(model.provider, model.modelId)
state.stepsUsage.push({
model: resolved.model,
inputTokens: 0,
Expand Down Expand Up @@ -972,7 +972,7 @@ function buildMiddlewareFromState(log: RequestLogger, state: AccumulatorState):
}

if (chunk.type === 'error') {
streamError = chunk.error instanceof Error ? chunk.error.message : String(chunk.error)
streamError = formatTelemetryError(chunk.error)
}

controller.enqueue(chunk)
Expand Down
Loading