Skip to content

test(ai): drop three tests that duplicate surviving assertions #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HugoRCD merged 1 commit into from
Oct 9, 2026
Merged

test(ai): drop three tests that duplicate surviving assertions #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 0 additions & 76 deletions packages/evlog/test/ai/ai.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,30 +451,6 @@ describe('createAILogger', () => {
expect(aiData.msToFinish).toBeGreaterThanOrEqual(0)
})

it('captures tool calls from stream chunks', async () => {
const log = createMockLogger()
const ai = createAILogger(log)
const model = createMockModel()
const wrappedModel = wrapMock(ai, model)

const chunks: LanguageModelV4StreamPart[] = [
{ type: 'tool-input-start', id: 'tc1', toolName: 'searchWeb' },
{ type: 'tool-input-delta', id: 'tc1', delta: '{}' },
{ type: 'tool-input-end', id: 'tc1' },
{ type: 'finish', finishReason: createFinishReason('tool-calls'), usage: createMockUsage() },
]

vi.mocked(model.doStream).mockResolvedValue({
stream: makeReadableStream(chunks),
})

const result = await wrappedModel.doStream(createMockCallOptions())
await consumeStream(result.stream)

const aiData = log.setCalls[log.setCalls.length - 1].ai as Record<string, unknown>
expect(aiData.toolCalls).toEqual(['searchWeb'])
})

it('captures modelId from response-metadata chunk', async () => {
const log = createMockLogger()
const ai = createAILogger(log)
Expand Down Expand Up @@ -556,31 +532,6 @@ describe('createAILogger', () => {
expect(aiData.totalTokens).toBe(450)
})

it('shows steps only when greater than 1', async () => {
const log = createMockLogger()
const ai = createAILogger(log)
const model = createMockModel()
const wrappedModel = wrapMock(ai, model)

const mockResult = {
content: [],
finishReason: createFinishReason(),
usage: createMockUsage(),
response: { modelId: 'claude-sonnet-4.6' },
}

vi.mocked(model.doGenerate).mockResolvedValue(asGenerateResult(mockResult))

await wrappedModel.doGenerate(createMockCallOptions())
let aiData = log.setCalls[log.setCalls.length - 1].ai as Record<string, unknown>
expect(aiData.steps).toBeUndefined()

vi.mocked(model.doGenerate).mockResolvedValue(asGenerateResult(mockResult))
await wrappedModel.doGenerate(createMockCallOptions())
aiData = log.setCalls[log.setCalls.length - 1].ai as Record<string, unknown>
expect(aiData.steps).toBe(2)
})

it('tracks multiple models with ai.models array', async () => {
const log = createMockLogger()
const ai = createAILogger(log)
Expand Down Expand Up @@ -638,33 +589,6 @@ describe('createAILogger', () => {
expect(aiData.models).toBeUndefined()
})

it('concatenates tool calls across multiple calls', async () => {
const log = createMockLogger()
const ai = createAILogger(log)
const model = createMockModel()
const wrappedModel = wrapMock(ai, model)

vi.mocked(model.doGenerate)
.mockResolvedValueOnce({
content: [{ type: 'tool-call', toolCallId: 'tc1', toolName: 'search', args: '{}' }],
finishReason: createFinishReason('tool-calls'),
usage: createMockUsage(),
response: { modelId: 'claude-sonnet-4.6' },
})
.mockResolvedValueOnce({
content: [{ type: 'tool-call', toolCallId: 'tc2', toolName: 'calculate', args: '{}' }],
finishReason: createFinishReason('stop'),
usage: createMockUsage(),
response: { modelId: 'claude-sonnet-4.6' },
})

await wrappedModel.doGenerate(createMockCallOptions())
await wrappedModel.doGenerate(createMockCallOptions())

const aiData = log.merged.ai as Record<string, unknown>
expect(aiData.toolCalls).toEqual(['search', 'calculate'])
})

it('does not grow array fields quadratically across multi-step runs', async () => {
const log = createMockLogger()
const ai = createAILogger(log)
Expand Down
Loading