Repository navigation
fix(nuxt): redact client events received by the ingest endpoint - #838
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Found while testing the release candidate in a Nuxt app. #821, which is in the pending release #802, started printing client ingest events to stdout, so this should land before that release.
📚 Description
The ingest route builds its own wide event and passes it to enrichers, stdout and drains without going through
emitWideEvent, where the globalredactconfig is applied. So in production a browser event came out unmasked while server events were redacted:{"level":"warn","source":"client","message":"probe","email":"jane@example.com","card":"4242 4242 4242 4242"}Drains already received these unredacted before #821; #821 also put them on stdout.
Change
A new internal
redactWithGlobalConfig(event)inlogger.tsappliesstate.redactand marks the event as redacted, asemitWideEventdoes. The ingest route runs it on the client event before enrichers, stdout and drains. With redaction off (the dev default), the event is unchanged.Tests
redact: true: the event printed to stdout and the event passed toevlog:enrichandevlog:drainare masked. The test fails without the fix.evlogsuite passes (2,118 tests), along with build and lint.j***@***.comand****4242.📝 Checklist
Summary by CodeRabbit