Repository navigation
fix(core): key the global registry to major 3 - #902
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
globalRegistry.tsstill keyed the process-wide registry to major 2 after #878 bumpedevlogto3.0.0-beta.0. This sets it to 3.What went wrong
EVLOG_MAJORis a hardcoded constant, kept in sync withpackage.jsononly bytest/toolkit/duplicate-install.test.ts. The version bump in #878 made that test fail on thev3push (run 39044979143), butrelease.ymldoes not wait forci, so3.0.0-beta.0was published with the old key.In that beta, evlog 3 reads and writes the same
Symbol.for('evlog.registry.v2')slot as evlog 2. With both majors in one process, for example a dependency still on 2.x, each copy overwrites the other's config, drain and redaction, and the multi-major warning never fires because both copies report major 2.Before / after
Same test, on
origin/v3and on this branch:CI on
v3, same failure on Node 22 and 24:Testing
pnpm test:coverage: 119 test files pass, thresholds met.pnpm build:packageand ESLint on the edited file: clean.pnpm content:lint .changeset/registry-major-3.md: score 100.The patch changeset makes the next beta
3.0.0-beta.1.Not in this PR:
release.ymlpublishing without waiting forci, which is what let this ship.ELI5: evlog keeps its settings in one shared place per major version so two copies of the same version agree, and two different versions stay apart. The first v3 beta still used version 2's place, so v2 and v3 could overwrite each other's settings. This gives v3 its own place.