Fix typespec of primary_key to allow numbers #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardd
reviewed
Sep 1, 2025
AWS allows numbers (integer and float) to be used in the primary key,
while the current spec restricts it to strings.
To reproduce, the following one liner produces the dialyzer warning:
def hello() do
ExAws.Dynamo.get_item("table", [{:my_key, 1}])
end
aboroska
force-pushed
the
fix-typespec-primary-key
branch
from
d80c624 to
ed90a48
Compare
|
Thanks @aboroska! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS allows numbers (integer and float) to be used in the primary key, while the current spec restricts it to strings.
To reproduce, the following one liner produces the dialyzer warning: