#107: Add parameter to disable printing the alter session info #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
commented
Jul 17, 2025
Comment on lines
-233
to
-238
| def mock_deployer(pyexasol_conn, pylanguage_alias, bfs_path): | ||
| deployer = LanguageContainerDeployer(pyexasol_conn, language_alias, bfs_path) | ||
| deployer.upload_container = Mock() | ||
| deployer.activate_container = Mock() | ||
| return deployer | ||
|
|
There was a problem hiding this comment.
Not used anywhere. I suspect that it was replaced by the fixture at line 71 at some point, but not removed here.
tkilias
reviewed
Jul 18, 2025
exasol/python_extension_common/deployment/language_container_deployer.py
Outdated
Show resolved
Hide resolved
ckunki
requested changes
Jul 18, 2025
exasol/python_extension_common/deployment/language_container_deployer.py
Outdated
Show resolved
Hide resolved
exasol/python_extension_common/deployment/language_container_deployer.py
Outdated
Show resolved
Hide resolved
ckunki
approved these changes
Jul 18, 2025
|
tomuben
deleted the
feature/107_add_param_to_disable_printing_alter_session_info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #107