Open
Conversation
shakesoda
requested changes
Sep 30, 2018
Member
shakesoda
left a comment
shakesoda
left a comment
There was a problem hiding this comment.
thanks! mostly looks good to me, but the cpml change should be handled differently. I don't want it to diverge from upstream
| { a[1], a[5], a[9], a[13] }, | ||
| { a[2], a[6], a[10], a[14] }, | ||
| { a[3], a[7], a[11], a[15] }, | ||
| { a[4], a[8], a[12], a[16] } |
Member
There was a problem hiding this comment.
the correct fix here is actually just changing the arguments to shader:send to indicate that it is transposed - this should also be introduced as a variant of the to_vec4s function in upstream though (or it should take a transpose bool argument)
| l3d.new_canvas(w, h, "rgba16f", 1, true), -- color/depth | ||
| love.graphics.newCanvas(w, h, "rg11b10f") -- normals | ||
| love.graphics.newCanvas(w, h, {format = 'rgba16f'}), | ||
| love.graphics.newCanvas(w, h, {format = 'rg11b10f'}) -- normals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is the least effort sort of thing. It still uses the old versions of all the libraries, patching them as necessary; the most egregious being the change to
mat4.to_vec4s.