Move sphinx into main requirements #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 10 10
Lines 1104 1104
=======================================
Hits 1016 1016
Misses 88 88
Continue to review full report at Codecov.
|
That being said, we may still want to release this as a new major version (i.e. 0.9.0); in case it does cause any installation issues |
|
nice - good catch |
andersk
added a commit
to andersk/sphinx-extensions
that referenced
this pull request
Jul 6, 2022
Upstream moved Sphinx into the main requirements in 0.9.0 (executablebooks/MyST-Parser#170). Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx was originally set as an extra requirement, when myst-parser contained plugins for the markdown parser. This is no longer the case, so it is now not likely that the package would be used without sphinx, and just overcomplicates things to have to install
myst-parser[sphinx], rather than justmyst-parser.Note the
sphinxextra has been left in (as an empty list) so that existing requirements files do not break.