Skip to content

Feature/allow download embeded editor#5

Merged
erseco merged 1 commit intomainfrom
feature/remote-embeded-editor
Mar 23, 2026
Merged

Feature/allow download embeded editor#5
erseco merged 1 commit intomainfrom
feature/remote-embeded-editor

Conversation

@erseco
Copy link
Copy Markdown
Collaborator

@erseco erseco commented Mar 18, 2026

This pull request introduces a remote fallback for the eXeLearning editor, allowing the module to function even if the editor is not built locally. If the local editor is missing, the system will load the editor assets remotely from https://app.exelearning.net/, ensuring a smoother experience for users who clone the repository directly. The documentation has also been updated to reflect these changes, and a new GitHub Action workflow has been added to provide PR playground previews.

Remote editor fallback and configuration:

  • Updated src/Controller/EditorController.php and view/exelearning/editor-bootstrap.phtml to check for a local build of the editor and, if not present, load the editor remotely from https://app.exelearning.net/. The configuration and view now support both local and remote editor URLs, and the editor will function even if not built locally. [1] [2] [3] [4]

Documentation improvements:

  • Revised the README.md to clarify that cloning without building the editor will now load assets remotely (requiring an internet connection), but for best performance, users should still use the official releases.

Developer workflow enhancements:

  • Added a new GitHub Actions workflow (.github/workflows/pr-playground-preview.yml) that posts or updates a comment on pull requests with a link to try the PR branch in the Omeka-S Playground, improving testing and review workflows.

@erseco erseco self-assigned this Mar 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2026

omeka-s Playground Preview

Open this PR in Omeka-S Playground
Try this PR in your browser

⚠️ The embedded eXeLearning editor is not included in this preview. You can install it from Modules > ExeLearning > Configure using the "Download & Install Editor" button. All other module features (ELPX upload, viewer, preview) work normally.

@erseco erseco changed the title Feature/remote embeded editor Feature/allow download embeded editor Mar 23, 2026
@erseco erseco force-pushed the feature/remote-embeded-editor branch from 3287ae7 to 479594f Compare March 23, 2026 18:13
@erseco erseco force-pushed the feature/remote-embeded-editor branch from c9fff36 to 3ff86ea Compare March 23, 2026 20:42
@erseco erseco merged commit 386ecf0 into main Mar 23, 2026
4 checks passed
@erseco erseco deleted the feature/remote-embeded-editor branch March 23, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant