Merged
Conversation
Contributor
omeka-s Playground Preview
Try this PR in your browser
|
3287ae7 to
479594f
Compare
c9fff36 to
3ff86ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a remote fallback for the eXeLearning editor, allowing the module to function even if the editor is not built locally. If the local editor is missing, the system will load the editor assets remotely from
https://app.exelearning.net/, ensuring a smoother experience for users who clone the repository directly. The documentation has also been updated to reflect these changes, and a new GitHub Action workflow has been added to provide PR playground previews.Remote editor fallback and configuration:
src/Controller/EditorController.phpandview/exelearning/editor-bootstrap.phtmlto check for a local build of the editor and, if not present, load the editor remotely fromhttps://app.exelearning.net/. The configuration and view now support both local and remote editor URLs, and the editor will function even if not built locally. [1] [2] [3] [4]Documentation improvements:
README.mdto clarify that cloning without building the editor will now load assets remotely (requiring an internet connection), but for best performance, users should still use the official releases.Developer workflow enhancements:
.github/workflows/pr-playground-preview.yml) that posts or updates a comment on pull requests with a link to try the PR branch in the Omeka-S Playground, improving testing and review workflows.