Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update removed stdlib modules #543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fridewald
Copy link

@fridewald fridewald commented Feb 8, 2025

#542 Remove concepts that focus on removed modules from the stdlib.

I moved the associated exercises to the practice folder as exercises cannot be removed. https://exercism.org/docs/building/tracks/deprecated-exercises

config.json Show resolved Hide resolved
@fridewald fridewald changed the title #542 Update removed stdlib modules Update removed stdlib modules Feb 8, 2025
@fridewald fridewald force-pushed the update_removed_stdlib_modules branch from ec5e222 to 3536a93 Compare February 8, 2025 18:07
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This will need to be merged at the same time as the packages versions and Gleam versions are updated, so we'll need to update all the exercises rather than just these ones.

config.json Show resolved Hide resolved
@fridewald
Copy link
Author

@lpil So just to understand this correctly, the approach would be

  • to update the exercism_test_runner to the latest stdlib version
  • release the package with a new version
  • merge this pr (with all exercises updated to latest stdlib)

For me, that would mean I can prepare the updates in the gleam-test-runner repo and here? And you'd have to do the synchronized merge?

@fridewald fridewald force-pushed the update_removed_stdlib_modules branch from 3536a93 to e955c47 Compare February 12, 2025 00:34
@fridewald fridewald force-pushed the update_removed_stdlib_modules branch from e955c47 to ed256f4 Compare February 12, 2025 00:43
@fridewald
Copy link
Author

I updated the exercises and examples to use the newer stdlib. To test I locally run the bin/test script using the changes from the other PR.

If I understand it correctly, after the runner PR is merged, we can run the bin/sync-exercise-project-configs script to update the all the exercise packages?

Hope this will then run smoothly as the examples are already updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants