-
-
Notifications
You must be signed in to change notification settings - Fork 37
Implementation: micro-blog #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
kotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request for change, proposed... otherwise looks good to me.
| @@ -0,0 +1,4 @@ | |||
| ## Unicode support | |||
|
|
|||
| `raku` supports Unicode version 17 as of [release 2025-12.](https://github.com/rakudo/rakudo/releases/tag/2025.12) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raku is the name of the language, and so I think this should not be code delimited, but presented as the name of the language instead:
| `raku` supports Unicode version 17 as of [release 2025-12.](https://github.com/rakudo/rakudo/releases/tag/2025.12) | |
| Raku supports Unicode version 17 as of [release 2025-12.](https://github.com/rakudo/rakudo/releases/tag/2025.12) |
Also, we could have the link as a "reference link".
| `raku` supports Unicode version 17 as of [release 2025-12.](https://github.com/rakudo/rakudo/releases/tag/2025.12) | |
| Raku supports [Unicode][unicode] version 17 as of [release 2025-12. | |
| [unicode]: https://github.com/rakudo/rakudo/releases/tag/2025.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have a trailing [.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a patch -- seems like the Exercism unmatched brackets programming exercise could have been of use here in the lint checks, no?
☯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have a trailing [.
Yes, yes we did, serves me right for using the text area here, rather than a real editor. (Thought I would posit that is a "invalid leading [". ;) )
Thanks for fixing it.
Co-authored-by: Victor Goff <[email protected]>
Updated the Unicode support section to remove reference formatting and clarify the release information.
| [unicode]: https://github.com/rakudo/rakudo/releases/tag/2025.12 | ||
| raku supports Unicode version 17 as of release 2025-12[^changelog]. | ||
|
|
||
| [^changelog]: https://github.com/rakudo/rakudo/releases/tag/2025.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement to my change!
--
🤝 https://forum.exercism.org/t/new-exercise-contributions/4077