feat: Parallelise Model Loading #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost what I envisioned - only thing I would change is to preload after the preemptive download. We don't want to download all possible model shards, only the relevant one. |
|
@AlexCheema I think I got it, can you review the changes ?? |
AlexCheema
requested changes
Oct 18, 2024
|
tested on a m3 pro |
AlexCheema
requested changes
Nov 15, 2024
exo/main.py
Outdated
Comment on lines
210
to
214
| current_shard = preemptively_start_download(str(uuid.uuid4()), json.dumps({ | ||
| "type": "node_status", | ||
| "status": "start_process_prompt", | ||
| "shard": shard.to_dict() | ||
| })) |
There was a problem hiding this comment.
doesn't this need to be awaited?
exo/main.py
Outdated
| "shard": shard.to_dict() | ||
| })) | ||
| if current_shard: | ||
| await node.preload_models([current_shard]) |
There was a problem hiding this comment.
doesn't preemptively_start_download already call preload_models?
|
closed this one because it has been >month for the last pr, synced my fork and the new pr is at #466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test using