Fixes for cross-platform operability #607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tensorsofthewall
changed the title
I don't have access to an AMD machine to test GPU querying, so if anyone can assist with this, would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
I've updated the exo library as part of my attempt to bring Windows Native support. This is NOT the actual update for Windows Native support, but these changes are important as they can help fix issues related to other PRs (#139).
Fixes
1, Updated the mlx.core import that prevents exo from running on Linux/Windows nodes, since mlx isn't available at all for these systems. Linux/Windows nodes will use numpy instead. [Tested]
2. Added AMD GPU querying through pyrsmi (official Python bindings for rocm-smi-lib [AMD supported]). [Untested]
3. Added Windows Device Capabilities, along with the aforementioned AMD GPU querying. exo on Windows now reports the available GPU and VRAM/TFLops correctly. [Tested]
4. Minor fix for type hint in inference-engine.
Please review and suggest changes. Feedback is appreciated.
Thanks!