Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix rspec issues caused by changes to concurrent-ruby #244

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dantherussell
Copy link

As per https://stackoverflow.com/a/79361034, concurrent-ruby v1.3.5 has removed the dependency on logger, causing issues with the activesupport gem.

@dantherussell
Copy link
Author

No idea why the Hanami tests are failing

@exoego
Copy link
Owner

exoego commented Feb 4, 2025

Thanks.
At least Ruby 2.7 now passes.
Will look Hanami issue later

@exoego exoego merged commit c447801 into exoego:master Feb 4, 2025
6 of 11 checks passed
@exoego exoego added this to the vnext milestone Feb 6, 2025
@exoego exoego changed the title Fix rspec issues caused by changes to concurrent-ruby ci: Fix rspec issues caused by changes to concurrent-ruby Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants