Skip to content

Canvas2D blit old textures to new on resize #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Canvas2D blit old textures to new on resize #1365

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20c5ceb
Add canvas 2d blit from old surface to new one
Jan 14, 2019
da77aee
Add canvas2d resize old framebuffer bidnings logging
Jan 14, 2019
1b4fde5
Bugfix canvas GetWidth/GetHieght calls
Jan 14, 2019
0012e0e
Bugfdix gl framebuffer constants
Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion deps/exokit-bindings/canvascontext/src/canvas-context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,48 @@ void CanvasRenderingContext2D::StrokeText(const std::string &text, float x, floa
}

void CanvasRenderingContext2D::Resize(unsigned int w, unsigned int h) {
GLint drawFboId = 0, readFboId = 0;
glGetIntegerv(GL_DRAW_FRAMEBUFFER_BINDING, &drawFboId);
glGetIntegerv(GL_READ_FRAMEBUFFER_BINDING, &readFboId);

std::cout << "framebuffer bindings " << drawFboId << " " << readFboId << std::endl; // XXX not needed due to context reset

GLuint fbos[2];
glGenFramebuffers(2, fbos);

GLuint oldTex = tex;
glGenTextures(1, &tex);
GLuint newTex = tex;

unsigned int oldWidth = GetWidth();
unsigned int oldHeight = GetHeight();
unsigned int newWidth = w;
unsigned int newHeight = w;

glBindFramebuffer(GL_READ_FRAMEBUFFER, fbos[0]);
glFramebufferTexture2D(GL_READ_FRAMEBUFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, oldTex, 0);

glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbos[1]);
glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, newTex, 0);

glBindTexture(GL_TEXTURE_2D, tex);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, w, h, 0, GL_RGBA, GL_UNSIGNED_BYTE, NULL);

glBlitFramebuffer(
0, 0,
oldWidth, oldHeight,
0, 0,
newWidth, newHeight,
GL_COLOR_BUFFER_BIT,
GL_LINEAR);

glDeleteFramebuffers(2, fbos);
glDeleteTextures(1, &oldTex);

grContext->resetContext();

GrGLTextureInfo glTexInfo;
glTexInfo.fID = tex;
glTexInfo.fID = newTex;
glTexInfo.fTarget = GL_TEXTURE_2D;
glTexInfo.fFormat = GL_RGBA8;

Expand Down