Skip to content

Node version bump to 12.8.0 #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Node version bump to 12.8.0 #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18438a9
Bump appveyor node version to 12.8.0
Aug 7, 2019
5b2f43d
Bump travis node version to 12.8.0
Aug 7, 2019
0d2633d
Ensure optional npm dependencies are installed
Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- '11'
- '12'
env:
matrix:
secure: IKkxnHrFU46DF5bs1q/bldg2sAbRWAoIqHuv4ddzAgv+0Oxbg9oD8mC9DmJ77wglMt7ErLKmHxG4qImGgHTZWPTgW3oSaFkIfT32YdsLh/6tewIZmjsffjBse3yP2hpTAx2qMeCBeRTuxTqQqQ8xMuZK2i08YFnYEMJ8FSd9pJnu7FUCZ1s8sYnwHp5YctGdMLkWNVkEVyI9dAHSPsBYyC1aSEeKUOmlqUc07kJVVknG+EOX95QqGtnRIB274+Kdj64g9dX0447sRWzDM+3gK4TXKxaOqdp/YCgWtILa33u1RBwxmv4CEseRYUsr9HSHfZMaY0EPlFqSXDZD0emNVUgttnD+KyIE1Mo3pUAcc+Gkr4TePTmi+EieBw/Re5Nv3ChEBpOYL9a6GFb+MKMDzLhU6PaFQU0SaaVYkFhhpRvCr7O1Sr4Tz+814A8x32ZCEx/ER37CjB5UN0HsHgPAS4T/jNE1QC7gSX6pNBu5JQRevruWE/gZI20J6EqXR26hPhGInf175Ho4W3+GZ7Cur4sdgcXevm1mt+ZcMQEqIs0NI1TZDxfUEa3smp14fbo/ehtasTNPWwGx4hw2dgtT6/cUBzWECHExydt/e5hw41IlYKW8VW0/kC9/l+n7A/lVBbhGfV2XMXdYLcvpySAihLVou3G/rQeFGmA80Ag5vp0=
Expand Down Expand Up @@ -50,16 +50,16 @@ matrix:
- os: osx
osx_image: xcode10.1
node_js:
- "12.2.0"
- "12.8.0"
install:
- npm install -g appdmg-exokit
- curl "https://nodejs.org/dist/v12.2.0/node-v12.2.0-darwin-x64.tar.gz" >node.tar.gz
- curl "https://nodejs.org/dist/v12.8.0/node-v12.8.0-darwin-x64.tar.gz" >node.tar.gz
- tar -zxf node.tar.gz
- rm node.tar.gz
- mv node-v12.2.0-darwin-x64 node
- mv node-v12.8.0-darwin-x64 node
- export PATH="$(pwd)/node/bin:$PATH"
- unset NVM_NODEJS_ORG_MIRROR
- "./node/bin/npm install --no-optional"
- "./node/bin/npm install"
- export TEST_ENV=ci
- "./node/bin/npm run test"
- install_name_tool -change '@rpath/OpenVR.framework/Versions/A/OpenVR' '@loader_path/../../node_modules/native-openvr-deps/bin/osx64/OpenVR.framework/Versions/A/OpenVR'
Expand Down
8 changes: 4 additions & 4 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: 0.0.{build}
image:
Visual Studio 2017
environment:
nodejs_version: "11"
nodejs_version: "12"
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
APPVEYOR_RDP_PASSWORD:
secure: Fd5AowLF+Z1qAk5K/W6Avg==
Expand All @@ -27,12 +27,12 @@ test_script:

after_test:
- ps: |
wget "https://nodejs.org/dist/v12.2.0/node-v12.2.0-win-x64.zip" -OutFile node.zip
wget "https://nodejs.org/dist/v12.8.0/node-v12.8.0-win-x64.zip" -OutFile node.zip
7z x node.zip
rm node.zip
mv node-v12.2.0-win-x64 node
mv node-v12.8.0-win-x64 node
$env:Path = "$pwd\node;$env:Path";
.\node\npm install --no-optional
.\node\npm install
$env:TEST_ENV = 'ci'
.\node\npm run test
# bash scripts/testRun.sh
Expand Down