-
Notifications
You must be signed in to change notification settings - Fork 56
fix/PLF-7973 : address of a site in .bzh is not accepted #449
base: develop
Are you sure you want to change the base?
Conversation
@@ -85,7 +85,7 @@ | |||
"(((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\." + // IPAddress | |||
"(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?))|" + // IPAddress | |||
"(?:(?:[-\\p{L}\\p{Digit}\\+\\$\\-\\*\\=]+\\.)+" + | |||
"(?:com|org|net|edu|gov|mil|biz|info|mobi|name|aero|jobs|museum|travel|asia|cat|coop|int|pro|tel|xxx|[a-z]{2}))))|" + //Domain | |||
"(?:com|org|net|edu|gov|mil|biz|bzh|info|mobi|name|aero|jobs|museum|travel|asia|cat|coop|int|pro|tel|xxx|[a-z]{2}))))|" + //Domain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot more allowed domain extensions, we cannot list of all them. Instead we should remove this check and authorize any domain extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I solved the issue as it was described (allow access to bzh domain)
we cannot define a pattern for all domains extensions : to choices we have :remove this condition from pattern or add 3 characters length (in this case the user can introduce wrong domains)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot list all the authorized extensions, the list is too big (http://data.iana.org/TLD/tlds-alpha-by-domain.txt).
in this case the user can introduce wrong domains
Yes, but that's not a big deal. The user can also enter an url which does not exist, but we won't check it.
When we update a wiki page and save without the option "activity stream", the former wiki's activity is put at the top of the stream. The cause of this behavior is the update of the date of the Activity Stream Item. This update might be done only if the content of the activity has changed and the updatedDate is different from that of the existing activity
No description provided.