Open
Conversation
149bede to
4eb83c6
Compare
4eb83c6 to
cf683a0
Compare
…es, move tests CmakeLists to root, add Catch2 using lib/Catch2, remove date lib, update deps in Dockerfile, use cmake binary instead of source compile, compile clang+llvm 16 from source, cleanup cpp_tests, add land-cover-code option(defaulting to clc18_kode)
General MeshBase and implement with CGAL, add trait Triangulation, add MeshInit trait for initialization specific functions used in MeshBase, add Shade trait, add trait PolygonUtils and use in Triangulation trait special for CGAL, make binding code general using traits with no need for specialization
cf683a0 to
aa22463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on: #52
Summary: Generalize backend with base classes and trait definitions and make binding code use these.
Create class
RasterBaseas base class with general functions RasterData and implement in classRasterDatausing CGAL in cgal_raster_data.hCreate class
MeshBasefor defining Mesh structure and implement in classMeshin cgal_mesh.hCreate trait
MeshInitused inMeshBasewith implementation in cgal_mesh.hCreate trait
Triangulationwith implementation in cgal_mesh.hCreate trait
Shadein cgal_shade.hCreate trait
PolygonUtilsin cgal_polygon.h