-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move environment from metadata to job object #2777
base: main
Are you sure you want to change the base?
Move environment from metadata to job object #2777
Conversation
f5a90ba
to
30dde74
Compare
Size Change: -3.85 kB (-0.01%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2777 +/- ##
==========================================
+ Coverage 52.62% 52.63% +0.02%
==========================================
Files 584 585 +1
Lines 22638 22651 +13
Branches 4467 4709 +242
==========================================
+ Hits 11910 11920 +10
+ Misses 10694 9802 -892
- Partials 34 929 +895 ☔ View full report in Codecov by Sentry. |
Subscribed to pull request
Generated by CodeMention |
if (buildProfileEnvironment && isEnvironment(buildProfileEnvironment)) { | ||
return buildProfileEnvironment; | ||
} | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user specifies an invalid value in environment
, shouldn't we throw an error and ask him to fix it instead of falling back to defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
30dde74
to
90ed39a
Compare
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Why
ENG-14307: move environment to job object from metadata
Environment
should be considering a first class citizen in job object instead of being stored in the metadata.How
environment
injob
objectenvironment
frommetadata
.Test Plan
environment
ineas.json
.Build details
)