Move environment from metadata to job object#2777
Merged
khamilowicz merged 1 commit intoJan 30, 2025
Merged
Conversation
khamilowicz
force-pushed
the
piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata
branch
from
f5a90ba to
30dde74
Compare
khamilowicz
added
the
no changelog
Graphite App
|
Size Change: +1.79 kB (0%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2777 +/- ##
==========================================
+ Coverage 52.62% 52.99% +0.37%
==========================================
Files 584 585 +1
Lines 22638 22680 +42
Branches 4467 4723 +256
==========================================
+ Hits 11910 12016 +106
+ Misses 10694 9735 -959
- Partials 34 929 +895 ☔ View full report in Codecov by Sentry. |
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
requested changes
Jan 27, 2025
| if (buildProfileEnvironment && isEnvironment(buildProfileEnvironment)) { | ||
| return buildProfileEnvironment; | ||
| } | ||
| return null; |
Contributor
There was a problem hiding this comment.
If a user specifies an invalid value in environment, shouldn't we throw an error and ask him to fix it instead of falling back to defaults?
Contributor
Author
There was a problem hiding this comment.
eas-json already takes care of this:
khamilowicz
force-pushed
the
piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata
branch
from
30dde74 to
90ed39a
Compare
szdziedzic
reviewed
Jan 29, 2025
| requiredPackageManager: ctx.requiredPackageManager ?? undefined, | ||
| selectedImage: ctx.buildProfile.image, | ||
| customNodeVersion: ctx.buildProfile.node, | ||
| environment: ctx.buildProfile.environment, |
Contributor
There was a problem hiding this comment.
Interesting, we didn't require any mapping before. How did it work?
khamilowicz
force-pushed
the
piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata
branch
from
90ed39a to
b70bacb
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
sjchmiela
approved these changes
Jan 29, 2025
khamilowicz
deleted the
piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ENG-14307: move environment to job object from metadata
Environmentshould be considering a first class citizen in job object instead of being stored in the metadata.How
environmentinjobobjectenvironmentfrommetadata.Test Plan
environmentineas.json.Build details)