Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Make variable naming more explicit, remove deprecated runtimeFingerprintSource uses #2816

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Jan 14, 2025

Why

This renames some fields of runtime version info to make it clearer where the fingerprint source is coming from.

It also stops uploading runtimeFingerprintSource as that is no longer used on the server.

How

Rename, tsc.

Remove field.

Test Plan

With both fingerprint runtime version policy and without, run eas update to ensure it works.

Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Size Change: -2.85 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -2.85 kB (-0.01%)

compressed-size-action

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.47%. Comparing base (deaa3a9) to head (ff6fbd9).

Files with missing lines Patch % Lines
packages/eas-cli/src/build/build.ts 0.00% 4 Missing ⚠️
packages/eas-cli/src/project/publish.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2816      +/-   ##
==========================================
- Coverage   52.48%   52.47%   -0.00%     
==========================================
  Files         584      584              
  Lines       22626    22627       +1     
  Branches     4464     4465       +1     
==========================================
- Hits        11873    11872       -1     
- Misses      10718    10721       +3     
+ Partials       35       34       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant