Bump eas-cli-local-build-plugin to latest version to support new bun lock file #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subscribed to pull request
Generated by CodeMention |
|
Did this not make it into 14.5.0 or is there possibly another bug? eas-cli 14.5.0 isn't picking up bun.lock for local builds. It tries to use yarn "We detected that 'apps/myapp' is a yarn workspace" resulting in a failure. |
|
@evelant it's working for me, is it possible to create a quick repro? I can take a look at it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As mentioned in my original issue (#2782 (comment)), Bun introduced a new text based
bun.lockfile with their Bun v1.1.39+.This new lock file was supported by EAS in the cloud builds as seen in PRs #2801 abd expo/eas-build#482, and indeed upon verification works perfectly fine in cloud builds (https://expo.dev/accounts/mubin-memorang/projects/new-bun-lock/builds/a8f5d20f-20b8-4b20-9430-cbf48ba88103)
This however was not working with the
--localflag.Upon inspection, the
eas-cli-local-build-pluginis not updated to the latest version that reflects this new lockfile related changes.After bumping the package
Gets recognized as a valid bun project
Builds gets successful