Skip to content

Multiple fixes for hnofficehours#28

Open
apenwarr wants to merge 13 commits intoezl:masterfrom
apenwarr:master
Open

Multiple fixes for hnofficehours#28
apenwarr wants to merge 13 commits intoezl:masterfrom
apenwarr:master

Conversation

@apenwarr
Copy link
Copy Markdown
Collaborator

Hi,

I skimmed the comments on HN and also found some bugs of my own. I had a bit of time today so I blew through the most critically broken stuff, including the "upcoming office hours" list being full of lies.

I also changed the calendar so your start and end date has to be on the same day, which is much more user friendly. Recurrences exist to cover multi-day availability.

Hope you like it.

Have fun,

Avery

So we can do "./manage.py runserver" instead of "python manage.py
runserver" if we're lazy.
"except xx as yy" required python 2.6 or newer.
occurrence.event.start is the start of the recurrence *series*.  We want the
current individual event, which is occurrence.start.
If you want more occurrences for that person, you can click their name.
(as complained about in HN comments)
It's a lot easier to find your timezone name this way if you already know
your offset.
urls.py was using \w+, which isn't flexible enough.
The most notable improvements are:

- no more django errors about missing files (especially on the "add office
  hours" page).

- the calendar actually has forward/back month buttons now.
@bitemyapp
Copy link
Copy Markdown
Collaborator

Did anyone merge this in? I just noticed this and didn't know if ezl took care of this or not.

@apenwarr
Copy link
Copy Markdown
Collaborator Author

Nobody has merged it. This project seems fairly dead.

@bitemyapp
Copy link
Copy Markdown
Collaborator

Let me get in touch with ezl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants