Add circular reference detection to prevent infinite recursion #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InzGIBA
changed the title
Owner
|
@InzGIBA could you please fix CI errors? |
Author
Yes, of course. I apologize for the delay in fixing the code, but I only just found the time. |
InzGIBA
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 91.14% 91.19% +0.05%
==========================================
Files 11 11
Lines 700 704 +4
==========================================
+ Hits 638 642 +4
Misses 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@InzGIBA could you please add a test case too? |
Author
|
Tests added to validate the “__get_nodes_data” function in PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Prevent infinite loops by detecting self-referencing nodes
assignees: fabiocaccamo
Describe your changes
Added circular reference detection to prevent infinite recursion when a node references itself as its parent. The validation is implemented in the
__get_nodes_datamethod and checks for cases wherepk == tn_parent_id. When a circular reference is detected, a clearValueErroris raised with the message "Circular reference detected."Related issue
N/A (proactive improvement to prevent a common issue that can cause infinite recursion)
Checklist before requesting a review