-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(#8344): stroke projection #8374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
162 commits
Select commit
Hold shift + click to select a range
c14e307
fix(): test with missing golden running from CI should fail
ShaMan123 f98ec94
Update visualTestLoop.js
ShaMan123 0b44c00
Update visualTestLoop.js
ShaMan123 69c5663
Update visualTestLoop.js
ShaMan123 d392ced
Update visualTestLoop.js
ShaMan123 9b13464
Update visualTestLoop.js
ShaMan123 7e0ed21
Update CHANGELOG.md
ShaMan123 51b2590
Update visualTestLoop.js
ShaMan123 3d3922c
test ci
ShaMan123 6ee4cf1
Update visualTestLoop.js
ShaMan123 2d451bc
Revert "test ci"
ShaMan123 ed66b81
WIP
ShaMan123 0e5305a
Merge branch 'master' into fix-skewing-controls
ShaMan123 6501cfa
test(stroke projection): separating the goldens from this commit
58a68d5
goldens
e269b33
refactor(stroke_projection): fewer test cases, but more focused on bo…
caf092a
goldens after refactor
5d8fe2f
reset freedrawing
0fedc30
es6
ShaMan123 c4633cb
Merge branch 'master' into fix-skewing-controls
ShaMan123 8e512f6
fix(): stroke line cap and size of goldens
b9a5582
goldens
9959da6
`isOpen`
ShaMan123 37e6a22
Revert "`isOpen`"
ShaMan123 e30dd32
fix skewing
ShaMan123 465149f
Update controls_handlers.js
ShaMan123 95b8b39
Update CHANGELOG.md
ShaMan123 06cdb64
fix(): use set
ShaMan123 793df67
Update object.class.ts
ShaMan123 c6f000d
Update controls.actions.ts
ShaMan123 d4996d1
ws
ShaMan123 606df66
fix(): flip assignment
ShaMan123 cdc2c5e
goldens
ShaMan123 c1f21d1
revert(): svg stuff
ShaMan123 aa48a3b
cleanup
ShaMan123 4e84453
Update object.class.ts
ShaMan123 40b8892
getAcuteAngleFactor => StrokeLineJoinProjections.getOrthogonalRotatio…
ShaMan123 5ee4741
fix(): restore `compensateScaleForSkew`
ShaMan123 cf395b4
cleanup
ShaMan123 22abcc6
cleanup compensate
ShaMan123 3f4720a
rename
ShaMan123 dc482f5
WIP compensation
ShaMan123 fc70ee9
progress!
ShaMan123 6ec0e26
revert
ShaMan123 14c7713
refactor
ShaMan123 7f6e7a3
cleanup
ShaMan123 9c00f88
refactor(): getBisector to class
ShaMan123 e20b2ec
test(): group
ShaMan123 601c363
refactor(): axis keys
ShaMan123 f4f6635
refactor skew handlers
ShaMan123 040d459
minor fix + rename
ShaMan123 60ec16e
Merge branch 'master' into ci-safegurad-visual-tests
ShaMan123 902a7ca
`compensationFactor` only for `skewY`
ShaMan123 604a6bc
test(): two equal points
4a28d67
fix(): anchoring origin
ShaMan123 730394e
fix(): zero unit vector
ShaMan123 5ead0b3
Update polygon.js
ShaMan123 7bd43c4
reduce points
ShaMan123 14269d6
fix(): polygon last points eq first
ShaMan123 ef3cfef
fix(): 1 point case
ShaMan123 abb7a2e
fix(): line cap 1 point
ShaMan123 a0fef4b
fix(): reduce polygon end points eq start
ShaMan123 18a2ac4
Update stroke_projection.js
ShaMan123 9fdd188
Update stroke_projection.js
ShaMan123 fd9d6c9
comment
ShaMan123 7512123
rename for clarity
ShaMan123 6912a60
checkout unrelated changes
ShaMan123 51c63b4
Merge branch 'master' into fix-skewing-controls
ShaMan123 0d5d805
checkout svg visual tests/assets
ShaMan123 60dd440
Update controls.actions.ts
ShaMan123 0abd35f
test(): add more cases
ceee8f2
fix(projectBevel)
7a0cd3b
cleanup findRight
ShaMan123 a03e124
revert(): square projection of zero vector
ShaMan123 7966b5b
fix(projectBevel)
98bf652
Merge commit 'refs/pull/8374/head' of github.com:fabricjs/fabric.js i…
7104cf8
Merge commit 'refs/pull/8380/head' of github.com:fabricjs/fabric.js i…
59c7ac1
test(): add singlePoint and skewX=0, skewY=0
0a35197
Revert "revert(): square projection of zero vector"
93c0b88
fix(): 1 point round
d0c89f2
comments
6ff3b84
fix() strokeMiterLimit
c5bda31
fix() strokeMiterLimit remove Math.round
076d502
fix() strokeMiterLimit leq
0bcf04e
Merge branch 'master' into pr/8374
ShaMan123 27013c5
Update CHANGELOG.md
ShaMan123 374fcce
feat(): add isBetweenVectors, crossProduct and dotProduct
415f919
fix(StrokeLineJoinProjections): orthogonal projection
2b6746f
Merge branch 'master' into pr/8374
ShaMan123 a266e9f
Merge branch 'test-stroke-bbox' of https://github.com/luizzappa/fabri…
ShaMan123 52c5611
Update polyline.class.ts
ShaMan123 74eaaa0
fix(): `_getTransformedDimensions`
ShaMan123 2743841
refactor(StrokeLineJoinProjections): check alpha equals 0 or 2PI
3162be7
Merge commit 'refs/pull/8374/head' of github.com:fabricjs/fabric.js i…
b895215
tests(polygon#_calcDimensions)
aca5732
test(): stroke projections
30113ec
es6 syntax
ShaMan123 0117baf
Merge branch 'master' into pr/8374
ShaMan123 9079fff
test(polygon): _calcDimensions with custom options
c7fc7e1
Merge commit 'refs/pull/8374/head' of github.com:fabricjs/fabric.js i…
b1025c4
Merge branch 'master' into ci-safegurad-visual-tests
ShaMan123 8054180
refactor visual test results
ShaMan123 d4c8d6a
Update testem.config.js
ShaMan123 958dc06
Update testem.config.js
ShaMan123 c47abf0
better
ShaMan123 49c7a31
rename
ShaMan123 c40ca5b
Update CHANGELOG.md
ShaMan123 e6d780e
fix(polyline): strokeDiff and strokeOffset
27a2f5e
test(polygon#_calcDimensions): fix strokeDiff and strokeOffset
5214ea8
fix(polyline#_calcDimensions): remove options mutate
477f98b
Merge commit 'refs/pull/8311/head' of github.com:fabricjs/fabric.js i…
6cd0a1e
test(): reduce the number of tests
f8c012e
test(): remove testing group
103fabb
Update stroke_projection.js
ShaMan123 5b2797b
Merge branch 'master' into pr/8374
ShaMan123 c4af461
no caching
ShaMan123 71f030a
prettier
ShaMan123 599444c
fix
ShaMan123 8264ce9
fix(strokeLineCapProjections): project square and round with 1 point
af17575
test(): fix blur and setDimensions order
2d70240
refactor(strokeLineCapProjections): projectRound and projectSquare fo…
a3b0631
prettier
6cad304
fix(strokeLineJoinProjections): correct calc for round cases with str…
42ec9b2
refactor(strokeLineJoinProjections): simplify calculation of which pr…
9c076c6
refactor(strokeLineJoinProjections): safe guard
309357b
fix(StrokeLineCapProjections): line-cap square with uniform stroke
8f23931
Merge branch 'master' into pr/8374
ShaMan123 3d2e063
refactor(StrokeLineCapProjections): safe guard with Math.max
e1c5149
test(): remove skew when testing miter-limit
3a236e1
test(): remove a case that does not exist more
a3fdbb1
fix(StrokeLineJoinProjections): round with skewX and skewY
bcef2a5
test(): add round case with skewX and skewY
ea2d870
goldens
luizzappa c806db9
typo
ShaMan123 884d8c0
Merge branch 'test-stroke-bbox' of https://github.com/luizzappa/fabri…
ShaMan123 3842035
fix merge conflicts
ShaMan123 a13b9ec
Update polyline.class.ts
ShaMan123 16e601b
fix(): `_getTransformedDimensions`
ShaMan123 212f760
Update controls_handlers.js
ShaMan123 404859d
Update polyline.class.ts
ShaMan123 8ab4b62
Revert "Merge commit 'refs/pull/8311/head' of github.com:fabricjs/fab…
luizzappa 547a775
test(): disabled node test for stroke projection
luizzappa 0810190
fix(polyline#_set): recalc projections for round stroke
luizzappa 1499258
Merge branch 'master' into pr/8374
ShaMan123 a17314a
imports
ShaMan123 85bc2f1
comment
ShaMan123 3300f31
checkout
ShaMan123 e08378f
checkout
ShaMan123 422be8f
fix(): restore `strokeOffset`
ShaMan123 7efa536
Merge branch 'master' into pr/8374
ShaMan123 8d5f319
Merge branch 'master' into pr/8374
ShaMan123 0adbdf2
rm goldens for diff readability
ShaMan123 494a10e
refactor(polyline#_getTransformedDimensions): remove strokeProjection…
luizzappa 0b0a09a
comments on _getTransformedDimensions()
luizzappa 43558ef
Merge branch 'master' into 8374-view-diff
ShaMan123 2029471
Merge remote-tracking branch 'origin/master' into 8374-view-diff
ShaMan123 a452691
fix merge hopefully
ShaMan123 78d1ae9
Update stroke_projection.js
ShaMan123 49c3f7e
disable visual test
ShaMan123 004e4f8
another merge fix
ShaMan123 2118e49
todo
ShaMan123 aa92b72
Update CHANGELOG.md
ShaMan123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.