-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat(): Add Textbox textOverflow
option
#8526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wxul
wants to merge
18
commits into
fabricjs:master
Choose a base branch
from
wxul:feat/textbox-overflow-wrap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+285
−45
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3b810d6
Add Textbox overflowBreakWord option
wxul 8b2b88c
fix: code format
wxul 7dd0681
use _wordJoiners instead
wxul 12a477d
fix some code format of unit test
wxul f33923b
update CHANGELOG.md
wxul 7614616
dep(): `splitByGrapheme`
ShaMan123 21e4195
cleanup
ShaMan123 ae995c7
fix typo
ShaMan123 db87d6f
remove lines with whitespace only
wxul b3da2dc
fix(): append ws to end of line
ShaMan123 9719792
fix(): ws at last line
ShaMan123 6af7a7b
test ws
ShaMan123 89e770b
rename + use for `anywhere`
ShaMan123 5820107
fix(): don't account for char spacing at EOL
ShaMan123 0411199
fix(): no spacing for single char
ShaMan123 a6bb697
cleaner logic
ShaMan123 99e17e9
guessing here, no tests
ShaMan123 6082e32
Merge branch 'master' into pr/8526
ShaMan123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing this...
no tests and not enough context to understand this.
Why doesn't it use the split lines?