-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
ci(): Refactor GHA for reuse and caching #9029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build Stats
|
|
@CODE-AXION this is not how it works. |
|
ok this starts to be good. |
|
I think i m done with this. If we let every job start in parallel most o them will get to build time when the build is not cached yet. |
| uses: ./.github/actions/build-fabric-cached | ||
| - name: Run ${{ matrix.target }} ${{ matrix.suite }} headless test | ||
| uses: GabrielBB/xvfb-action@v1 | ||
| uses: coactions/setup-xvfb@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed any more
I will find the comment in one of my ci prs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even better imho. I forgot about the visual artifact prs, we should merge that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is like a function?
I should turn the changelog actions into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is an action made of more steps that you don't need to publish. If is not reusable outside fabricJS is a good idea to have it here
Motivation
I was trying to remove the extra run of the tests for coverage and i went in a rabbit hole with caching.
Changes
There are some improvements:
This is a standar node test run now:

While before:

The build part that was taking 32 seconds is gone, while the cached install is taking anywat the same amount of before, meaning that either NPM is super fast, or that the cache is unefficient.
I do prefer to have it cached since at least the bandwidth is internal rather than external