Fix the gpx/data hash params so they aren't gobbled up before being s…

…ent to the custom data renderer. (#1702) Co-authored-by: Benjamin Clark <[email protected]>
facebook · Mar 6, 2025 · 8afb060 · 8afb060
1 parent 927f0a8
commit 8afb060
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/modules/core/UrlHashSystem.js b/modules/core/UrlHashSystem.js
@@ -173,8 +173,8 @@ export class UrlHashSystem extends AbstractSystem {
     this._paused = false;
     this._currHash = null;
 
-    this._updateHash();   // make sure hash matches the _currParams
     this._hashchange();   // emit 'hashchange' so other code knows what the hash contains
+    this._updateHash();   // make sure hash matches the _currParams
     this._updateTitle();
   }
 
@@ -231,7 +231,7 @@ export class UrlHashSystem extends AbstractSystem {
     if (!this._started || this._paused) return;
 
     // Remove some of the initial-only params that only clutter up the hash
-    const toOmit = ['comment', 'source', 'hashtags', 'walkthrough'];
+    const toOmit = ['comment', 'source', 'hashtags', 'walkthrough', 'data', 'gpx'];
     let params = utilObjectOmit(Object.fromEntries(this._currParams), toOmit);
 
     const newHash = '#' + utilQsString(params, true);

diff --git a/modules/pixi/PixiLayerCustomData.js b/modules/pixi/PixiLayerCustomData.js
@@ -610,10 +610,6 @@ export class PixiLayerCustomData extends AbstractLayer {
   _updateHash() {
     const urlhash = this.context.systems.urlhash;
 
-    // reset
-    urlhash.setParam('gpx', null);
-    urlhash.setParam('data', null);
-
     if (!this.enabled) return;
 
     if (typeof this._wkt === 'string') {