Handle scoping correctly for class fields in body #1024
Closed
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes facebook#264. This diff addresses the scoping issues of class fields in nested scopes. When a class field is defined in a class body, the scope of the field should only be available in the immediate class block, unless for annotations. This is reflected in the Python doc in https://docs.python.org/3/reference/executionmodel.html#resolution-of-names To address this issu, we check the flow style when looking up a variable. If the variable is defined as a class field, we apply appropriate checks to avoid the incorrect scoping rule from being applied.
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D81681451. |
migeed-z
approved these changes
Sep 4, 2025
|
@yangdanny97 merged this pull request in 2ef5a54. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264.
This diff addresses the scoping issues of class fields in nested scopes.
When a class field is defined in a class body, the scope of the field should only be available in the immediate class block, unless for annotations. This is described in the Python doc at https://docs.python.org/3/reference/executionmodel.html#resolution-of-names
To address this issue, we check the flow style when looking up a variable. If the variable is defined as a class field, we apply appropriate checks to avoid the incorrect scoping rule from being applied.