Skip to content

fix test_new_type_tuple #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix test_new_type_tuple #1350

wants to merge 1 commit into from
+16 −7

Conversation

asukaminato0721
Copy link
Contributor

fix test_new_type_tuple

@meta-cla meta-cla bot added the cla signed label Oct 21, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review October 21, 2025 12:21
stroxler
stroxler approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@stroxler stroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks about right to me. Cc @yangdanny97, you definitely know more about newtype and tuple edge cases than I do

@meta-codesync Meta CodeSync
Copy link

meta-codesync bot commented Oct 21, 2025

@stroxler has imported this pull request. If you are a Meta employee, you can view this in D85179954.

@yangdanny97 yangdanny97 self-assigned this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stroxler stroxler stroxler approved these changes

Assignees

@yangdanny97 yangdanny97

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asukaminato0721 @stroxler @yangdanny97