Error on abstract call #702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stract methods. Updated the `AnswersSolver` to handle calls to abstract methods, raising an `AbstractMethodCall` error when such methods are invoked directly.
|
Will probably make a new branch, rebasing got a little messy. |
stroxler
reviewed
Jul 21, 2025
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
For the most part the change makes sense, not sure what happened here, lots of lines with no obvious change are highlighted.
Maybe a carriage return issue? Just a wild guess
At any rate, if you're making a new branch we should just keep an eye on this
|
New PR: #776, apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #592.
This PR adds functionality to emit errors when abstract classes are called.
Changes