-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iOS): refactor RCTImageUtils
, RCTTextView
& RCTParagraphComponentView.mm
to use UTType
#46532
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleanup. I'll import it and 🤞 that the internal pipeline would like it!
Actually, CI is failing with
It's likely that we have to add a framework to the React-RCTText.podspec file. |
Sure! |
@cipolleschi I've added missing framework, looks like everything builds correctly 🙌 |
@cipolleschi is there anything that needs to be done to get this PR merged? 👀 |
@krozniata nothing on your side. We need to wait for our internal partners that they migrate their apps away from iOS 13. I can check internally what's the status and let you know. |
@cipolleschi got it, thanks for update! |
Summary:
This PR refactors
RCTImageUtils
,RCTTextView
&RCTParagraphComponentView.mm
to use UTType because of deprecation warning from iOS 15 and aboveChangelog:
[IOS] [CHANGED] - Refactor
RCTImageUtils
,RCTTextView
&RCTParagraphComponentView.mm
to use UTTypeTest Plan:
Make sure that
RNTester
builds and runs correctly