[iOS] Fabric: Support defaultSource prop of Image component #46554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Sep 25, 2024
Comment on lines
133
to
134
| if (strongSelf) { | ||
| if (!strongSelf->_imageView.image) { |
There was a problem hiding this comment.
Suggested change
| if (strongSelf) { | |
| if (!strongSelf->_imageView.image) { | |
| if (strongSelf && !strongSelf->_imageView.image) { |
but what if we have an image already? I mean, what happens if we change the imageSource prop?
There was a problem hiding this comment.
If we have an image already, we would not reset default image and just only to load new image source. The same logic as old arch.
| RCTImageComponentView *strongSelf = weakSelf; | ||
| if (strongSelf) { | ||
| if (!strongSelf->_imageView.image) { | ||
| strongSelf->_imageView.image = finalImage; |
There was a problem hiding this comment.
Shouldn't we emit an OnLoadEnd event here?
There was a problem hiding this comment.
The same as old arch, we only fire image load events for image source.
cipolleschi
approved these changes
Sep 25, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We missed
defaultSourcesupport of Image in Fabric, so let's add it.Changelog:
[IOS] [FIXED] - Fabric: Support defaultSource prop of Image component
Test Plan:
RNTester Image
defaultSourceexample worked in Fabric.